tseeker-pub/rust-crafting-interpreters-part-1
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Resolver - Ensure method names are unique

Browse source
This commit is contained in:
Emmanuel BENOîT 2023-01-13 08:31:08 +01:00
parent 77f14bfa8e
commit 39276f4756
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/resolver.rs
View file

@ -1,4 +1,4 @@
use std::collections::HashMap; use std::collections::{HashMap, HashSet};
use crate::{ use crate::{
ast::{ClassMemberDecl, ExprNode, ProgramNode, StmtNode, VariableExpr}, ast::{ClassMemberDecl, ExprNode, ProgramNode, StmtNode, VariableExpr},
@ -273,10 +273,17 @@ fn resolve_class<'a, 'b>(
where where
'b: 'a, 'b: 'a,
{ {
let mut names = HashSet::new();
rs.define_this(); rs.define_this();
methods.iter().try_for_each(|member| match member { methods.iter().try_for_each(|member| match member {
ClassMemberDecl::Method(method) | ClassMemberDecl::StaticMethod(method) => rs.with_scope( ClassMemberDecl::Method(method) | ClassMemberDecl::StaticMethod(method) => rs.with_scope(
|rs| resolve_function(rs, &method.params, &method.body), |rs| {
if names.insert(method.name.lexeme.clone()) {
resolve_function(rs, &method.params, &method.body)
} else {
rs.error(&method.name, "duplicate method name")
}
},
if method.name.lexeme == "init" { if method.name.lexeme == "init" {
ScopeType::Initializer ScopeType::Initializer
} else { } else {