SQL logging fixes

* Added user mapping on the "remote" logging database for the
administrative user. This allows calls to sys.write_sql_log() to succeed
when they are executed by code with administrative privileges.

* Added test suites for both the link to the database and the function
itself.

* Replaced RAISE NOTICE with actual logging in the universe generator

legacyworlds-server-data/db-structure/tests/admin/020-extensions/010-dblink.sql

@@ -0,0 +1,40 @@
+/*
+ * Test the presence and configuration of the dblink
+ * extension
+ */
+BEGIN;
+	SELECT plan( 6 );
+	
+	SELECT diag_test_name( 'dblink - dblink_connect() exists' );
+	SELECT has_function( 'dblink_connect' );
+
+	SELECT diag_test_name( 'dblink - Foreign data wrapper defined' );
+	SELECT is( p.proname , 'postgresql_fdw_validator' )
+		FROM pg_foreign_data_wrapper w
+			INNER JOIN pg_proc p ON w.fdwvalidator = p.oid
+		WHERE w.fdwname = 'pgsql';
+
+	SELECT diag_test_name( 'dblink - Foreign server defined' );
+	SELECT is ( w.fdwname , 'pgsql' )
+		FROM pg_foreign_server s
+			INNER JOIN pg_foreign_data_wrapper w
+				ON s.srvfdw = w.oid
+		WHERE s.srvname = 'srv_logging';
+
+	SELECT diag_test_name( 'dblink - Connection' );
+	SELECT lives_ok(
+		$$ SELECT dblink_connect( 'cn_logging' , 'srv_logging' ) $$
+	);
+	
+	SELECT diag_test_name( 'dblink - Remote user is not the administrator' );
+	SELECT isnt( username , current_user::TEXT )
+		FROM dblink( 'cn_logging' , 'SELECT current_user' )
+			AS ( username TEXT );
+
+	SELECT diag_test_name( 'dblink - Disconnection' );
+	SELECT lives_ok(
+		$$ SELECT dblink_disconnect( 'cn_logging' ) $$
+	);
+
+	SELECT * FROM finish( );
+ROLLBACK;

legacyworlds-server-data/db-structure/tests/admin/040-functions/005-logs/010-write-sql-log.sql

@@ -0,0 +1,32 @@
+/*
+ * Test the sys.write_sql_log( ) function
+ */
+BEGIN;
+	DELETE FROM sys.logs;
+	SELECT plan( 4 );
+	
+	SELECT diag_test_name( 'sys.write_sql_log( ) - Initial call' );
+	SELECT lives_ok(
+		$$ SELECT sys.write_sql_log( 'test' , 'WARNING'::log_level , 'test' ) $$
+	);
+	SELECT diag_test_name( 'sys.write_sql_log( ) - Contents of system log after call' );
+	SELECT is( COUNT(*)::INT , 1 ) FROM sys.logs;
+	DELETE FROM sys.logs;
+	
+	SELECT diag_test_name( 'sys.write_sql_log( ) - Two calls in sequence' );
+	SELECT lives_ok(
+		$$ SELECT sys.write_sql_log( 'test' , 'WARNING'::log_level , 'test' );
+		SELECT sys.write_sql_log( 'test' , 'WARNING'::log_level , 'test' ) $$
+	);
+	DELETE FROM sys.logs;
+
+	SELECT diag_test_name( 'sys.write_sql_log( ) - Calling and rolling back' );
+	SAVEPOINT before_log;
+		SELECT sys.write_sql_log( 'test' , 'WARNING'::log_level , 'test' );
+		SELECT sys.write_log( 'test' , 'WARNING'::log_level , 'test' );
+	ROLLBACK TO SAVEPOINT before_log;	
+	SELECT is( COUNT(*)::INT , 1 ) FROM sys.logs;
+	DELETE FROM sys.logs;
+
+	SELECT * FROM finish( );
+ROLLBACK;

legacyworlds-server-data/db-structure/tests/user/020-extensions/010-dblink.sql

@@ -0,0 +1,23 @@
+/*
+ * Test the configuration of the dblink extension from the user's perspective
+ */
+BEGIN;
+	SELECT plan( 3 );
+	
+	SELECT diag_test_name( 'dblink - Connection' );
+	SELECT lives_ok(
+		$$ SELECT dblink_connect( 'cn_logging' , 'srv_logging' ) $$
+	);
+	
+	SELECT diag_test_name( 'dblink - Remote user = local user' );
+	SELECT is( username , current_user::TEXT )
+		FROM dblink( 'cn_logging' , 'SELECT current_user' )
+			AS ( username TEXT );
+
+	SELECT diag_test_name( 'dblink - Disconnection' );
+	SELECT lives_ok(
+		$$ SELECT dblink_disconnect( 'cn_logging' ) $$
+	);
+	
+	SELECT * FROM finish( );
+ROLLBACK;

legacyworlds-server-data/db-structure/tests/user/030-data/150-logs/010-sys-logs.sql

@@ -0,0 +1,29 @@
+/*
+ * Test privileges on sys.logs
+ */
+BEGIN;
+	SELECT plan( 4 );
+	
+	SELECT diag_test_name( 'sys.logs - INSERT privileges' );
+	SELECT throws_ok(
+		$$ INSERT INTO sys.logs( component , level , message )
+			VALUES ( 'test' , 'WARNING'::log_level , 'test' );
+		$$ , 42501 );
+
+	SELECT diag_test_name( 'sys.logs - UPDATE privileges' );
+	SELECT throws_ok(
+		$$ UPDATE sys.logs SET component = 'retest'; $$ ,
+		42501 );
+
+	SELECT diag_test_name( 'sys.logs - SELECT privileges' );
+	SELECT lives_ok(
+		$$ SELECT * FROM sys.logs; $$
+	);
+
+	SELECT diag_test_name( 'sys.logs - DELETE privileges' );
+	SELECT throws_ok(
+		$$ DELETE FROM sys.logs; $$ ,
+		42501 );
+
+	SELECT * FROM finish( );
+ROLLBACK;

legacyworlds-server-data/db-structure/tests/user/040-functions/005-logs/010-write-sql-log.sql

@@ -0,0 +1,13 @@
+/*
+ * Test the sys.write_sql_log( ) function
+ */
+BEGIN;
+	SELECT plan( 1 );
+	
+	SELECT diag_test_name( 'sys.write_sql_log( ) - Privileges' );
+	SELECT lives_ok(
+		$$ SELECT sys.write_sql_log( 'test' , 'WARNING'::log_level , 'test' ) $$
+	);
+
+	SELECT * FROM finish( );
+ROLLBACK;

legacyworlds-server-data/db-structure/tests/user/priv/sys/logs.sql

@@ -1,39 +0,0 @@
-BEGIN;
-	SELECT plan( 3 );
-
-	--
-	-- Insertion through sys.write_log()
-	--
-	CREATE OR REPLACE FUNCTION _test_this( )
-		RETURNS BIGINT
-	AS $$
-		SELECT sys.write_log( 'test' , 'WARNING'::log_level , 'test' );
-	$$ LANGUAGE SQL;
-	SELECT lives_ok( 'SELECT _test_this()' );
-	DROP FUNCTION _test_this( );
-
-	--
-	-- Direct insertion must fail
-	--
-	CREATE FUNCTION _test_this( )
-		RETURNS VOID
-	AS $$
-		INSERT INTO sys.logs( component , level , message )
-			VALUES ( 'test' , 'WARNING'::log_level , 'test' );
-	$$ LANGUAGE SQL;
-	SELECT throws_ok( 'SELECT _test_this()' , 42501 );
-	DROP FUNCTION _test_this( );
-
-	--
-	-- Updates must fail
-	--
-	CREATE OR REPLACE FUNCTION _test_this( )
-		RETURNS VOID
-	AS $$
-		UPDATE sys.logs SET component = 'random' WHERE component = 'test';
-	$$ LANGUAGE SQL;
-	SELECT throws_ok( 'SELECT _test_this()' , 42501 );
-	DROP FUNCTION _test_this( );
-	
-	SELECT * FROM finish( );
-ROLLBACK;